Optimize JS events

2025-10-15 10:19:04 +00:00 · 2025-08-09 16:56:36 +02:00
1 changed files with 16 additions and 6 deletions
--- a/GDJS/GDJS/Extensions/Builtin/CommonInstructionsExtension.cpp
+++ b/GDJS/GDJS/Extensions/Builtin/CommonInstructionsExtension.cpp
@@ -841,13 +841,23 @@ CommonInstructionsExtension::CommonInstructionsExtension() {
                  event.GetParameterObjects(),
                  parentContext.GetCurrentObject());

-          callingCode += "var objects = [];\n";
-          for (unsigned int i = 0; i < realObjects.size(); ++i) {
-            parentContext.ObjectsListNeeded(realObjects[i]);
+          if (realObjects.size() == 1) {
+            parentContext.ObjectsListNeeded(realObjects[0]);
            callingCode +=
-                "objects.push.apply(objects," +
-                codeGenerator.GetObjectListName(realObjects[i], parentContext) +
-                ");\n";
+                "const objects = " +
+                codeGenerator.GetObjectListName(realObjects[0], parentContext) +
+                ";\n";
+          } else {
+            // Groups are rarely used in JS events so it's fine to make
+            // allocations.
+            callingCode += "const objects = [];\n";
+            for (unsigned int i = 0; i < realObjects.size(); ++i) {
+              parentContext.ObjectsListNeeded(realObjects[i]);
+              callingCode += "objects.push.apply(objects," +
+                             codeGenerator.GetObjectListName(realObjects[i],
+                                                             parentContext) +
+                             ");\n";
+            }
          }
        }