Kalakoi/GDevelop
1
0
Fork 0
mirror of https://github.com/4ian/GDevelop.git synced 2025-10-15 10:19:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

On touch screens, allow instruction edition by touching them again when selected

Browse Source
This commit is contained in:
Florian Rival
2019-10-02 12:28:56 +02:00
committed by Florian Rival
parent f661b41d74
commit df166e4d5d
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
newIDE/app/src/EventsSheet/EventsTree/Instruction.js
View File

@@ -119,9 +119,15 @@ export default class Instruction extends React.Component<Props> {
[instructionParameter]: true,
[parameterType]: true,
})}
onClick={domEvent =>
this.props.onParameterClick(domEvent, parameterIndex)
}
onClick={domEvent => {
this.props.onParameterClick(domEvent, parameterIndex);
// On touchscreen, don't propagate the click to the instruction div,
// as it's listening for taps to simulate double "clicks".
if (this.props.screenType === 'touch') {
domEvent.stopPropagation();
}
}}
onKeyPress={event => {
if (event.key === 'Enter' || event.key === ' ') {
this.props.onParameterClick(event, parameterIndex);
@@ -195,7 +201,13 @@ export default class Instruction extends React.Component<Props> {
})}
onClick={e => {
e.stopPropagation();
this.props.onClick();
if (this.props.screenType === 'touch' && this.props.selected) {
// On touch screens, tapping again a selected instruction should edit it.
this.props.onDoubleClick();
} else {
this.props.onClick();
}
}}
onDoubleClick={e => {
e.stopPropagation();