mirror of
https://github.com/4ian/GDevelop.git
synced 2025-10-15 10:19:04 +00:00
Fix displaying Teach tab if no members (#7617)
Do not show in changelog
This commit is contained in:
@@ -44,6 +44,21 @@ const getDefaultGroup = ({ id }: {| id: string |}) => ({
|
||||
});
|
||||
|
||||
describe('groupMembersByGroupId', () => {
|
||||
test('Works if there are no members', () => {
|
||||
expect(
|
||||
groupMembersByGroupId({
|
||||
groups: [],
|
||||
members: [],
|
||||
memberships: [],
|
||||
})
|
||||
).toEqual({
|
||||
active: {
|
||||
NONE: { group: { id: 'none', name: 'none' }, members: [] },
|
||||
},
|
||||
inactive: [],
|
||||
});
|
||||
});
|
||||
|
||||
test("All members are returned in the NONE group if they don't have a group yet", () => {
|
||||
const user1 = getDefaultUser({ id: 'user-id-1' });
|
||||
const user2 = getDefaultUser({ id: 'user-id-2' });
|
||||
@@ -116,6 +131,7 @@ describe('groupMembersByGroupId', () => {
|
||||
})
|
||||
).toEqual({
|
||||
active: {
|
||||
NONE: { group: { id: 'none', name: 'none' }, members: [] },
|
||||
[group1.id]: { group: group1, members: [] },
|
||||
[group2.id]: { group: group2, members: [] },
|
||||
},
|
||||
@@ -145,6 +161,7 @@ describe('groupMembersByGroupId', () => {
|
||||
})
|
||||
).toEqual({
|
||||
active: {
|
||||
NONE: { group: { id: 'none', name: 'none' }, members: [] },
|
||||
[group1.id]: { group: group1, members: [user1, user2, user3, user5] },
|
||||
[group2.id]: { group: group2, members: [] },
|
||||
},
|
||||
|
@@ -20,7 +20,9 @@ export const groupMembersByGroupId = ({
|
||||
inactive: User[],
|
||||
|} => {
|
||||
if (!(groups && members && memberships)) return null;
|
||||
const membersByGroupId = {};
|
||||
const membersByGroupId = {
|
||||
NONE: { group: { id: 'none', name: 'none' }, members: [] },
|
||||
};
|
||||
const deactivatedMembers = [];
|
||||
members.forEach(member => {
|
||||
const membership = memberships.find(
|
||||
|
Reference in New Issue
Block a user