Remove effect

newIDE/app/src/UI/TreeView/index.js

@@ -121,15 +121,6 @@ const TreeView = <Item>({
   const [openedNodeIds, setOpenedNodeIds] = React.useState<string[]>([]);
   const [renamedItemId, setRenamedItemId] = React.useState<?string>(null);
   const contextMenuRef = React.useRef<?ContextMenuInterface>(null);
-  const [
-    contextMenuOpeningOptions,
-    setContextMenuOpeningOptions,
-  ] = React.useState<?{|
-    item: Item,
-    index: number,
-    x: number,
-    y: number,
-  |}>(null);
   const [
     openedDuringSearchNodeIds,
     setOpenedDuringSearchNodeIds,
@@ -299,6 +290,25 @@ const TreeView = <Item>({
     [reactDndType]
   );
 
+  const openContextMenu = React.useCallback(
+    ({
+      x,
+      y,
+      item,
+      index,
+    }: {|
+      item: Item,
+      index: number,
+      x: number,
+      y: number,
+    |}) => {
+      if (contextMenuRef.current) {
+        contextMenuRef.current.open(x, y, { item, index });
+      }
+    },
+    []
+  );
+
   const itemData: ItemData<Item> = getItemData<Item>(
     flattenedData,
     onOpen,
@@ -306,7 +316,7 @@ const TreeView = <Item>({
     setRenamedItemId,
     onEndRenaming,
     renamedItemId,
-    setContextMenuOpeningOptions,
+    openContextMenu,
     canMoveSelectionToItem,
     onMoveSelectionToItem,
     onEditItem,
@@ -325,17 +335,6 @@ const TreeView = <Item>({
     [searchText]
   );
 
-  // Open context menu when the opening options change.
-  React.useEffect(
-    () => {
-      if (contextMenuRef.current && contextMenuOpeningOptions) {
-        const { x, y, item, index } = contextMenuOpeningOptions;
-        contextMenuRef.current.open(x, y, { item, index });
-      }
-    },
-    [contextMenuOpeningOptions]
-  );
-
   return (
     <>
       <FixedSizeList