Remove dead code related to debugger opening

Don't show in changelog
This commit is contained in:
Florian Rival
2020-05-17 16:58:26 +02:00
committed by Florian Rival
parent 6326c185f4
commit 990f59d093
11 changed files with 14 additions and 17 deletions

View File

@@ -634,7 +634,6 @@ export default class EventsFunctionsExtensionEditor extends React.Component<
this.props.openInstructionOrExpression
}
setToolbar={this.props.setToolbar}
onOpenDebugger={() => {}}
onCreateEventsFunction={this.props.onCreateEventsFunction}
onOpenSettings={this._editOptions}
unsavedChanges={this.props.unsavedChanges}

View File

@@ -89,7 +89,6 @@ type Props = {|
objectsContainer: gdObjectsContainer,
events: gdEventsList,
setToolbar: (?React.Node) => void,
onOpenDebugger: () => void,
onOpenSettings?: ?() => void,
onOpenExternalEvents: string => void,
onOpenLayout: string => void,

View File

@@ -109,6 +109,11 @@ export default class BrowserS3PreviewLauncher extends React.Component<
});
};
getPreviewDebuggerServer() {
// Debugger server is not supported in the web-app.
return null;
}
render() {
const { showPreviewLinkDialog, url, error } = this.state;

View File

@@ -176,7 +176,9 @@ export default class LocalPreviewLauncher extends React.Component<
});
};
getPreviewDebuggerServer() { return LocalPreviewDebuggerServer; }
getPreviewDebuggerServer() {
return LocalPreviewDebuggerServer;
}
_checkSubscription = () => {
if (!this._subscriptionChecker) return true;

View File

@@ -12,7 +12,7 @@ export type PreviewOptions = {|
export type PreviewLauncherInterface = {
launchPreview: (options: PreviewOptions) => Promise<any>,
canDoNetworkPreview: () => boolean,
+getPreviewDebuggerServer: () => PreviewDebuggerServer,
+getPreviewDebuggerServer: () => ?PreviewDebuggerServer,
};
/** The props that PreviewLauncher must support */

View File

@@ -6,9 +6,7 @@ import {
type ResourceSource,
type ChooseResourceFunction,
} from '../../ResourcesList/ResourceSource.flow';
import {
type PreviewDebuggerServer,
} from '../../Export/PreviewLauncher.flow';
import { type PreviewDebuggerServer } from '../../Export/PreviewLauncher.flow';
import { type ResourceExternalEditor } from '../../ResourcesList/ResourceExternalEditor.flow';
export type RenderEditorContainerProps = {|
@@ -32,10 +30,9 @@ export type RenderEditorContainerProps = {|
layoutName: ?string,
externalLayoutName?: ?string
) => void,
previewDebuggerServer: PreviewDebuggerServer,
previewDebuggerServer: ?PreviewDebuggerServer,
// Opening other editors:
onOpenDebugger: () => void,
onOpenExternalEvents: string => void,
onOpenLayout: string => void,
openInstructionOrExpression: (

View File

@@ -67,8 +67,8 @@ export class DebuggerEditorContainer extends React.Component<
}
render() {
const { project } = this.props;
if (!project) return null;
const { project, previewDebuggerServer } = this.props;
if (!project || !previewDebuggerServer) return null;
return (
<React.Fragment>
@@ -76,7 +76,7 @@ export class DebuggerEditorContainer extends React.Component<
project={project}
setToolbar={this.props.setToolbar}
isActive={this.props.isActive}
previewDebuggerServer={this.props.previewDebuggerServer}
previewDebuggerServer={previewDebuggerServer}
ref={editor => (this.editor = editor)}
/>
<SubscriptionChecker

View File

@@ -60,7 +60,6 @@ export class EventsEditorContainer extends React.Component<RenderEditorContainer
<EventsSheet
ref={editor => (this.editor = editor)}
setToolbar={this.props.setToolbar}
onOpenDebugger={this.props.onOpenDebugger}
onOpenLayout={this.props.onOpenLayout}
resourceSources={this.props.resourceSources}
onChooseResource={this.props.onChooseResource}

View File

@@ -110,7 +110,6 @@ export class ExternalEventsEditorContainer extends React.Component<
<EventsSheet
ref={editor => (this.editor = editor)}
setToolbar={this.props.setToolbar}
onOpenDebugger={this.props.onOpenDebugger}
onOpenLayout={this.props.onOpenLayout}
resourceSources={this.props.resourceSources}
onChooseResource={this.props.onChooseResource}

View File

@@ -1653,7 +1653,6 @@ const MainFrame = (props: Props) => {
onChangeSubscription: () => openSubscriptionDialog(true),
projectItemName: editorTab.projectItemName,
setPreviewedLayout,
onOpenDebugger: openDebugger,
onOpenExternalEvents: openExternalEvents,
previewDebuggerServer:
_previewLauncher.current &&

View File

@@ -2692,7 +2692,6 @@ storiesOf('EventsSheet', module)
action('Choose resource from source', source)
}
resourceExternalEditors={fakeResourceExternalEditors}
onOpenDebugger={action('open debugger')}
onOpenLayout={action('open layout')}
onOpenSettings={action('open settings')}
setToolbar={() => {}}
@@ -2717,7 +2716,6 @@ storiesOf('EventsSheet', module)
action('Choose resource from source', source)
}
resourceExternalEditors={fakeResourceExternalEditors}
onOpenDebugger={action('open debugger')}
onOpenLayout={action('open layout')}
onOpenSettings={action('open settings')}
setToolbar={() => {}}