Fix some memory leaks in 2D object renderers (#5843)

Extensions/BBText/bbtextruntimeobject-pixi-renderer.ts

@@ -126,6 +126,10 @@ namespace gdjs {
     getHeight(): float {
       return this._pixiObject.height;
     }
+
+    destroy(): void {
+      this._pixiObject.destroy(true);
+    }
   }
 
   export const BBTextRuntimeObjectRenderer = BBTextRuntimeObjectPixiRenderer;

Extensions/BBText/bbtextruntimeobject.ts

@@ -132,6 +132,7 @@ namespace gdjs {
 
     onDestroyFromScene(instanceContainer: gdjs.RuntimeInstanceContainer): void {
       super.onDestroyFromScene(instanceContainer);
+      this._renderer.destroy();
     }
 
     /**

Extensions/PanelSpriteObject/panelspriteruntimeobject-pixi-renderer.ts

@@ -393,6 +393,18 @@ namespace gdjs {
     getTextureHeight() {
       return this._textureHeight;
     }
+
+    destroy() {
+      // Destroy textures because they are instantiated by this class.
+      for (const borderSprite of this._borderSprites) {
+        borderSprite.destroy({ texture: true });
+      }
+      this._centerSprite.destroy({ texture: true });
+      // Destroy the containers without handling children because they are
+      // already handled above.
+      this._wrapperContainer.destroy(false);
+      this._spritesContainer.destroy(false);
+    }
   }
 
   export const PanelSpriteRuntimeObjectRenderer = PanelSpriteRuntimeObjectPixiRenderer;

Extensions/PanelSpriteObject/panelspriteruntimeobject.ts

@@ -116,11 +116,7 @@ namespace gdjs {
 
     onDestroyFromScene(instanceContainer: gdjs.RuntimeInstanceContainer): void {
       super.onDestroyFromScene(instanceContainer);
-      // @ts-ignore
-      if (this._renderer.onDestroy) {
-        // @ts-ignore
-        this._renderer.onDestroy();
-      }
+      this._renderer.destroy();
     }
 
     update(instanceContainer: gdjs.RuntimeInstanceContainer): void {

Extensions/PrimitiveDrawing/shapepainterruntimeobject-pixi-renderer.ts

@@ -564,6 +564,10 @@ namespace gdjs {
         }
       }
     }
+
+    destroy(): void {
+      this._graphics.destroy();
+    }
   }
 
   export const ShapePainterRuntimeObjectRenderer = ShapePainterRuntimeObjectPixiRenderer;

Extensions/PrimitiveDrawing/shapepainterruntimeobject.ts

@@ -174,6 +174,11 @@ namespace gdjs {
       super.stepBehaviorsPreEvents(instanceContainer);
     }
 
+    onDestroyFromScene(instanceContainer: gdjs.RuntimeInstanceContainer): void {
+      super.onDestroyFromScene(instanceContainer);
+      this._renderer.destroy();
+    }
+
     /**
      * Clear the graphics.
      */

Extensions/TextObject/textruntimeobject-pixi-renderer.ts

@@ -203,6 +203,10 @@ namespace gdjs {
     setScaleY(newScale: float): void {
       this._text.scale.y = newScale;
     }
+
+    destroy() {
+      this._text.destroy(true);
+    }
   }
 
   // Register the class to let the engine use it.

Extensions/TextObject/textruntimeobject.ts

@@ -145,6 +145,11 @@ namespace gdjs {
       this._renderer.ensureUpToDate();
     }
 
+    onDestroyFromScene(instanceContainer: gdjs.RuntimeInstanceContainer): void {
+      super.onDestroyFromScene(instanceContainer);
+      this._renderer.destroy();
+    }
+
     /**
      * Initialize the extra parameters that could be set for an instance.
      */

Extensions/TileMap/tilemapruntimeobject-pixi-renderer.ts

@@ -122,6 +122,11 @@ namespace gdjs {
     getScaleY(): float {
       return this._pixiObject.scale.y;
     }
+
+    destroy(): void {
+      // Keep textures because they are shared by all tile maps.
+      this._pixiObject.destroy(false);
+    }
   }
   export const TileMapRuntimeObjectRenderer =
     gdjs.TileMapRuntimeObjectPixiRenderer;

Extensions/TileMap/tilemapruntimeobject.ts

@@ -158,6 +158,11 @@ namespace gdjs {
       );
     }
 
+    onDestroyFromScene(instanceContainer: gdjs.RuntimeInstanceContainer): void {
+      super.onDestroyFromScene(instanceContainer);
+      this._renderer.destroy();
+    }
+
     /**
      * Set the Tilemap file to display.
      */

Extensions/TiledSpriteObject/tiledspriteruntimeobject-pixi-renderer.ts

@@ -124,6 +124,11 @@ namespace gdjs {
     getTextureHeight() {
       return this._tiledSprite.texture.height;
     }
+
+    destroy(): void {
+      // Keep textures because they are shared by all sprites.
+      this._tiledSprite.destroy(false);
+    }
   }
 
   export const TiledSpriteRuntimeObjectRenderer = TiledSpriteRuntimeObjectPixiRenderer;

Extensions/TiledSpriteObject/tiledspriteruntimeobject.ts

@@ -73,9 +73,7 @@ namespace gdjs {
 
     onDestroyFromScene(instanceContainer: gdjs.RuntimeInstanceContainer): void {
       super.onDestroyFromScene(instanceContainer);
-      if ((this._renderer as any).onDestroy) {
-        (this._renderer as any).onDestroy();
-      }
+      this._renderer.destroy();
     }
 
     /**

Extensions/Video/videoruntimeobject-pixi-renderer.ts

@@ -54,6 +54,7 @@ namespace gdjs {
      */
     onDestroy() {
       this.stop();
+      this._pixiObject.destroy(false);
     }
 
     ensureUpToDate() {