Kalakoi/GDevelop
1
0
Fork 0
mirror of https://github.com/4ian/GDevelop.git synced 2025-10-15 10:19:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add check for libGD.js size in electron app build and fix failure reports

Browse Source
This commit is contained in:
Florian Rival
2020-03-05 07:57:31 +00:00
parent 372fa46709
commit 4362e8dd42
2 changed files with 54 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
newIDE/electron-app/scripts/app-build.js
View File

@@ -1,17 +1,55 @@
var shell = require('shelljs');
var args = require('minimist')(process.argv.slice(2));
const shell = require('shelljs');
const fs = require('fs');
const path = require('path');
const args = require('minimist')(process.argv.slice(2));
// Sanity check electron-builder installation
if (!shell.test('-f', './node_modules/.bin/electron-builder')) {
shell.echo('⚠️ Please run npm install in electron-app folder');
shell.exit(1);
}
if (!args['skip-app-build']) {
shell.cd('../app');
shell.exec('npm run build');
shell.cd('../electron-app');
}
// Sanity check libGD.js size
const checkLibGDjsSize = () =>
new Promise(resolve => {
fs.stat(path.join(__dirname, '../../app/public/libGD.js'), (err, stats) => {
if (err) {
shell.echo(
`❌ Unable to check libGD.js size. Have you compiled GDevelop.js? Error is: ${err}`
);
shell.exit(1);
}
shell.rm('-rf', 'app/www');
shell.mkdir('-p', 'app/www');
shell.cp('-r', '../app/build/*', 'app/www');
const sizeInMiB = stats.size / 1024 / 1024;
if (sizeInMiB > 5) {
shell.echo(
`❌ libGD.js size is too big (${sizeInMiB.toFixed(
2
)}MiB) - are you sure you're not trying to deploy the development version?`
);
shell.exit(1);
}
shell.echo(`✅ libGD.js size seems correct (${sizeInMiB.toFixed(2)}MiB)`);
resolve();
});
});
checkLibGDjsSize().then(() => {
if (!args['skip-app-build']) {
shell.cd('../app');
if (shell.exec('npm run build').code !== 0) {
shell.exit(1);
}
shell.cd('../electron-app');
}
shell.rm('-rf', 'app/www');
shell.mkdir('-p', 'app/www');
if (shell.cp('-r', '../app/build/*', 'app/www').code !== 0) {
shell.echo(
`❌ Copy from "../app/build" to Electron's "app/www" folder failed.`
);
shell.exit(1);
}
});

8
newIDE/electron-app/scripts/build.js
View File

@@ -8,7 +8,11 @@ if (!shell.test('-f', './node_modules/.bin/electron-builder')) {
}
if (!args['skip-app-build']) {
shell.exec('npm run app-build');
const { code } = shell.exec('npm run app-build');
if (code !== 0) {
shell.echo(`❌ App build failed with code ${code}.`);
shell.exit(code);
}
}
const electronBuilder = path.join('node_modules', '.bin', 'electron-builder');
@@ -17,7 +21,7 @@ shell.exec(
[electronBuilder, electronBuilderArguments.join(' ')].join(' '),
code => {
if (code !== 0) {
shell.echo('⚠️ Build failed with code =' + code);
shell.echo(`❌ Electron build failed with code ${code}.`);
}
shell.exit(code);
}