Kalakoi/GDevelop
1
0
Fork 0
mirror of https://github.com/4ian/GDevelop.git synced 2025-10-15 10:19:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Workaround a strange Electron behavior for confirming the closing of the app

Browse Source
This commit is contained in:
Florian Rival
2018-05-26 22:56:03 -07:00
parent 3fb6f0cd4e
commit 1a8fd09596
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
newIDE/app/src/UI/CloseConfirmDialog.js
View File

@@ -30,15 +30,18 @@ export default class CloseConfirmDialog extends React.Component<Props, *> {
if (electron) {
window.onbeforeunload = e => {
if (this._delayElectronClose && shouldPrompt) {
//eslint-disable-next-line
const answer = confirm(message);
// Use setTimeout to avoiding blocking the thread with the "confirm" dialog,
// which would make Electron to close the window for some weird reason.
// See https://github.com/electron/electron/issues/7977
setTimeout(() => {
//eslint-disable-next-line
const answer = confirm(message);
if (answer) {
// If answer is positive, re-trigger the close
this._delayElectronClose = false;
electron.remote.getCurrentWindow().close();
}
});
}, 10);
// Prevents closing the window immediately. See https://github.com/electron/electron/blob/master/docs/api/browser-window.md#event-close
e.returnValue = true; //"It is recommended to always set the event.returnValue explicitly, instead of only returning a value, as the former works more consistently within Electron.""