v2.8.0

Bump minimist from 1.2.5 to 1.2.6

__tests__/hiscores.test.ts

@@ -88,7 +88,7 @@ test('Parse CSV to json', () => {
   1,6143
   4814,898
   37,225
-  23,467
+  25,1110
   382,2780
   944,3000
   1981,1452
@@ -172,7 +172,7 @@ test('Parse CSV to json', () => {
     },
     lastManStanding: { rank: 4814, score: 898 },
     soulWarsZeal: { rank: 37, score: 225 },
-    riftsClosed: { rank: 23, score: 467 },
+    riftsClosed: { rank: 25, score: 1110 },
     clues: {
       all: { rank: 32, score: 12148 },
       beginner: { rank: 3105, score: 76 },
@@ -238,11 +238,9 @@ test('Parse CSV to json', () => {
 });
 
 test('Parse CSV with unknown activity', () => {
-  const statsWithUnknownActivity = `${lynxTitanStats}
+  const statsWithUnknownActivity = lynxTitanStats + `
     -1,-1`;
-  expect(() => parseStats(statsWithUnknownActivity)).toThrow(
+  expect(() => parseStats(statsWithUnknownActivity)).toThrow(INVALID_FORMAT_ERROR);
-    INVALID_FORMAT_ERROR
-  );
 });
 
 test('Parse invalid CSV', () => {

__tests__/lynxTitanStats.csv

@@ -29,7 +29,6 @@
 -1,-1
 -1,-1
 -1,-1
--1,-1
 347584,22
 -1,-1
 -1,-1
@@ -82,4 +81,5 @@
 -1,-1
 -1,-1
 -1,-1
+-1,-1
 -1,-1

package.json

@@ -1,6 +1,6 @@
 {
   "name": "osrs-json-hiscores",
-  "version": "2.7.0",
+  "version": "2.8.0",
   "description": "The Old School Runescape API wrapper that does more!",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

src/hiscores.ts

@@ -28,8 +28,7 @@ import {
   getActivityPageURL,
   httpGet,
   BOSSES,
-  INVALID_FORMAT_ERROR,
+  INVALID_FORMAT_ERROR
-  EXTRA_ACTIVITY_COUNT
 } from './utils';
 
 /**
@@ -76,14 +75,7 @@ export function parseStats(csv: string): Stats {
     .filter((entry) => !!entry)
     .map((stat) => stat.split(','));
 
-  if (
+  if (splitCSV.length !== SKILLS.length + BH_MODES.length + CLUES.length + BOSSES.length + 4) {
-    splitCSV.length !==
-    SKILLS.length +
-      BH_MODES.length +
-      CLUES.length +
-      BOSSES.length +
-      EXTRA_ACTIVITY_COUNT
-  ) {
     throw Error(INVALID_FORMAT_ERROR);
   }
 
@@ -113,10 +105,7 @@ export function parseStats(csv: string): Stats {
   const [leaguePoints] = activityObjects.splice(0, 1);
   const bhObjects = activityObjects.splice(0, BH_MODES.length);
   const clueObjects = activityObjects.splice(0, CLUES.length);
-  const [lastManStanding, soulWarsZeal, riftsClosed] = activityObjects.splice(
+  const [lastManStanding, soulWarsZeal, riftsClosed] = activityObjects.splice(0, 3);
-    0,
-    3
-  );
   const bossObjects = activityObjects.splice(0, BOSSES.length);
 
   const skills: Skills = skillObjects.reduce<Skills>((prev, curr, index) => {

src/utils/constants.ts

@@ -250,9 +250,4 @@ export const FORMATTED_SOUL_WARS = 'Soul Wars Zeal';
 export const FORMATTED_LEAGUE_POINTS = 'League Points';
 export const FORMATTED_RIFTS_CLOSED = 'Rifts Closed';
 
-/**
- * Count of activities not including bosses, bounty hunter, or clues.
- */
-export const EXTRA_ACTIVITY_COUNT = 4;
-
 export const INVALID_FORMAT_ERROR = 'Invalid hiscores format';

yarn.lock

@@ -4295,9 +4295,9 @@ minimist-options@^4.0.2:
     kind-of "^6.0.3"
 
 minimist@^1.1.1, minimist@^1.2.0, minimist@^1.2.5:
-  version "1.2.5"
+  version "1.2.6"
-  resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.5.tgz#67d66014b66a6a8aaa0c083c5fd58df4e4e97602"
+  resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.6.tgz#8637a5b759ea0d6e98702cfb3a9283323c93af44"
-  integrity sha512-FM9nNUYrRBAELZQT3xeZQ7fmMOBg6nWNmJKTcgsJeaLstP/UODVpGsr5OhXhhXg6f+qtJ8uiZ+PUxkDWcgIXLw==
+  integrity sha512-Jsjnk4bw3YJqYzbdyBiNsPWHPfO++UGG749Cxs6peCu5Xg4nrena6OVxOYxrQTqww0Jmwt+Ref8rggumkTLz9Q==
 
 mixin-deep@^1.2.0:
   version "1.3.2"