Kalakoi/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-10-15 02:49:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #110907 from beicause/extension-deconstruct-before-object

Browse Source 
Free script and extension instance before object deconstructing
This commit is contained in:
Thaddeus Crews
2025-09-30 18:35:10 -05:00
parent 76c039fb09 727066fe1f
commit 93fd5c7ad0
2 changed files with 46 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/core/object/test_object.h
View File

@@ -215,12 +215,12 @@ TEST_CASE("[Object] Construction") {
}
TEST_CASE("[Object] Script instance property setter") {
Object object;
Object *object = memnew(Object);
_MockScriptInstance *script_instance = memnew(_MockScriptInstance);
object.set_script_instance(script_instance);
object->set_script_instance(script_instance);
bool valid = false;
object.set("some_name", 100, &valid);
object->set("some_name", 100, &valid);
CHECK(valid);
Variant actual_value;
CHECK_MESSAGE(
@@ -229,20 +229,22 @@ TEST_CASE("[Object] Script instance property setter") {
CHECK_MESSAGE(
actual_value == Variant(100),
"The returned value should equal the one which was set by the object.");
memdelete(object);
}
TEST_CASE("[Object] Script instance property getter") {
Object object;
Object *object = memnew(Object);
_MockScriptInstance *script_instance = memnew(_MockScriptInstance);
script_instance->set("some_name", 100); // Make sure script instance has the property
object.set_script_instance(script_instance);
object->set_script_instance(script_instance);
bool valid = false;
const Variant &actual_value = object.get("some_name", &valid);
const Variant &actual_value = object->get("some_name", &valid);
CHECK(valid);
CHECK_MESSAGE(
actual_value == Variant(100),
"The returned value should equal the one which was set by the script instance.");
memdelete(object);
}
TEST_CASE("[Object] Built-in property setter") {