Remplace todo by comments.

This commit is contained in:
Davy Hélard
2022-11-08 15:25:58 +01:00
parent b45c448cdb
commit bb23e05edc
2 changed files with 7 additions and 7 deletions

View File

@@ -694,7 +694,7 @@ describe('gdjs.PlatformerObjectRuntimeBehavior', function () {
expect(object.getBehavior('auto1').isFalling()).to.be(false); expect(object.getBehavior('auto1').isFalling()).to.be(false);
expect(object.getBehavior('auto1').isOnFloor()).to.be(true); expect(object.getBehavior('auto1').isOnFloor()).to.be(true);
expect(object.getY()).to.be.within(140.6297999, 140.6298001); expect(object.getY()).to.be.within(140.6297999, 140.6298001);
// TODO Remove the 1-frame delay // The floor following has a 1-frame delay.
expect(object.getX()).to.be(5); expect(object.getX()).to.be(5);
runtimeScene.renderAndStep(1000 / 60); runtimeScene.renderAndStep(1000 / 60);
expect(object.getX()).to.be(6); expect(object.getX()).to.be(6);

View File

@@ -1,4 +1,4 @@
describe.only('gdjs.PlatformerObjectRuntimeBehavior', function () { describe('gdjs.PlatformerObjectRuntimeBehavior', function () {
const epsilon = 1 / (2 << 16); const epsilon = 1 / (2 << 16);
describe('(moving platforms)', function () { describe('(moving platforms)', function () {
@@ -68,7 +68,7 @@ describe.only('gdjs.PlatformerObjectRuntimeBehavior', function () {
runtimeScene.renderAndStepWithEventsFunction(1000 / 60, () => { runtimeScene.renderAndStepWithEventsFunction(1000 / 60, () => {
platform.setX(platform.getX() + 0.12); platform.setX(platform.getX() + 0.12);
}); });
// TODO Remove the 1-frame delay // The floor following has a 1-frame delay.
expect(object.getX()).to.be(0.24); expect(object.getX()).to.be(0.24);
runtimeScene.renderAndStep(1000 / 60); runtimeScene.renderAndStep(1000 / 60);
expect(object.getX()).to.be(0.36); expect(object.getX()).to.be(0.36);
@@ -258,13 +258,13 @@ describe.only('gdjs.PlatformerObjectRuntimeBehavior', function () {
// The object follow the platform // The object follow the platform
// The rounding error is probably due to a separate call. // The rounding error is probably due to a separate call.
// TODO Try to make it exact or find why // TODO Try to make it exact or find why
// TODO Remove the 1-frame delay // The floor following has a 1-frame delay.
expect(object.getY()).to.be.within( expect(object.getY()).to.be.within(
previousPlatformY - object.getHeight() - epsilon, previousPlatformY - object.getHeight() - epsilon,
previousPlatformY - object.getHeight() + epsilon previousPlatformY - object.getHeight() + epsilon
); );
} }
// TODO Remove the 1-frame delay // The floor following has a 1-frame delay.
expect(object.getX()).to.be(0 + 4 * deltaX); expect(object.getX()).to.be(0 + 4 * deltaX);
runtimeScene.renderAndStep(1000 / 60); runtimeScene.renderAndStep(1000 / 60);
expect(object.getX()).to.be(0 + 5 * deltaX); expect(object.getX()).to.be(0 + 5 * deltaX);
@@ -400,13 +400,13 @@ describe.only('gdjs.PlatformerObjectRuntimeBehavior', function () {
expect(object.getBehavior('auto1').isFalling()).to.be(false); expect(object.getBehavior('auto1').isFalling()).to.be(false);
expect(object.getBehavior('auto1').isMoving()).to.be(false); expect(object.getBehavior('auto1').isMoving()).to.be(false);
// The object must not be inside the platform or it gets stuck // The object must not be inside the platform or it gets stuck
// TODO Remove the 1-frame delay // The floor following has a 1-frame delay.
expect(object.getY()).to.be.within( expect(object.getY()).to.be.within(
previousPlatformY - object.getHeight() - epsilon, previousPlatformY - object.getHeight() - epsilon,
previousPlatformY - object.getHeight() + epsilon previousPlatformY - object.getHeight() + epsilon
); );
} }
// TODO Remove the 1-frame delay // The floor following has a 1-frame delay.
expect(object.getX()).to.be(0 + 4 * deltaX); expect(object.getX()).to.be(0 + 4 * deltaX);
runtimeScene.renderAndStep(1000 / 60); runtimeScene.renderAndStep(1000 / 60);
expect(object.getX()).to.be(0 + 5 * deltaX); expect(object.getX()).to.be(0 + 5 * deltaX);